InstanceOfPatternMatch: Generic type without parameters #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
reviewed
May 31, 2024
| oldTypeTree.withPrefix(Space.EMPTY), | ||
| null, | ||
| oldTypeTree.getType() | ||
| ).withTypeParameters(fqType.getTypeParameters().stream().map(p -> new J.Wildcard(randomId(), Space.EMPTY, Markers.EMPTY, null, null)).collect(Collectors.toList()) |
There was a problem hiding this comment.
Note to self : look at listutils to conform with code elsewhere.
There was a problem hiding this comment.
ListUtil.map() is for the same type lists, i.e. mapping of List<J> -> List<J> in my case it is List<JavaType> -> List<J>. I felt it is okay... the list can't be long... I only care about its size. If there are 5 type parameters i wanted to produce <?,?,?,?,?>. I can rerwrite this piece to conform to what i mentioned above better rather than have map
|
Thanks a lot for the thorough fix here! I'm still at Spring IO, but will merge this when not reviewing on mobile. :) |
|
Thanks a lot for the immediate fix @BoykoAlex ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit test and a possible straight-forward fix for
InstanceOfPatternMatchrecipe produces compiler error with generic types without type parameters #297